Sun, 01 May 2022 11:46:54 +0200
#170 no bug never existed
src/buffer.c | file | annotate | diff | comparison | revisions | |
test/test_buffer.cpp | file | annotate | diff | comparison | revisions |
1.1 --- a/src/buffer.c Sun May 01 11:44:23 2022 +0200 1.2 +++ b/src/buffer.c Sun May 01 11:46:54 2022 +0200 1.3 @@ -167,7 +167,6 @@ 1.4 // truncate data to be written, if we can neither extend nor flush 1.5 len = buffer->capacity - buffer->pos; 1.6 if (size > 1) { 1.7 - // TODO: this is bugged - it would only discard one element and not as many as required 1.8 len -= len % size; 1.9 } 1.10 nitems = len / size;
2.1 --- a/test/test_buffer.cpp Sun May 01 11:44:23 2022 +0200 2.2 +++ b/test/test_buffer.cpp Sun May 01 11:46:54 2022 +0200 2.3 @@ -362,11 +362,11 @@ 2.4 } 2.5 2.6 TEST_F(BufferWrite, MultibyteDiscard) { 2.7 - const char *data = "tester"; 2.8 + const char *data = "testing"; 2.9 ASSERT_EQ(buf.capacity, 8); 2.10 ASSERT_EQ(buf.size, 4); 2.11 buf.pos = 3; 2.12 - size_t written = cxBufferWrite(data, 2, 3, &buf); 2.13 + size_t written = cxBufferWrite(data, 2, 4, &buf); 2.14 // remember: whole elements are discarded if they do not fit 2.15 EXPECT_EQ(written, 2); 2.16 EXPECT_EQ(buf.size, 7);