# HG changeset patch # User Mike Becker # Date 1488813762 -3600 # Node ID a3597d704421efa10171fbc24d872ce579448a5a # Parent 661f33ef20d85ead42edeca20d79fbfd2a4048d9 safe one multiplication in overflow check for mempool_chcap() diff -r 661f33ef20d8 -r a3597d704421 ucx/mempool.c --- a/ucx/mempool.c Mon Mar 06 16:09:42 2017 +0100 +++ b/ucx/mempool.c Mon Mar 06 16:22:42 2017 +0100 @@ -109,8 +109,8 @@ void *ucx_mempool_malloc(UcxMempool *pool, size_t n) { if (pool->ndata >= pool->size) { - if (pool->size*2 < pool->size /* overflow check */ - || ucx_mempool_chcap(pool, pool->size*2)) { + size_t newcap = pool->size*2; + if (newcap < pool->size || ucx_mempool_chcap(pool, newcap)) { return NULL; } }