Thu, 10 Apr 2014 11:18:12 +0200
fixed ucx_list_remove crashing when removing the last element of a list
/* * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER. * * Copyright 2013 Olaf Wintermann. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE * POSSIBILITY OF SUCH DAMAGE. */ #include "list_tests.h" #include "ucx/utils.h" UCX_TEST(test_ucx_list_append) { UcxList *list = ucx_list_append(NULL, (void*)"Hello"); UCX_TEST_BEGIN UCX_TEST_ASSERT(strncmp((const char*)list->data, "Hello", 5) == 0, "failed"); list = ucx_list_append(list, (void*)" World!"); UCX_TEST_ASSERT(strncmp((const char*)list->next->data, " World!", 7) == 0, "failed"); UCX_TEST_ASSERT(list->next->next == NULL, "failed"); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_prepend) { UcxList *list = ucx_list_prepend(NULL, (void*)" World!"); UCX_TEST_BEGIN list = ucx_list_prepend(list, (void*)"Hello"); UCX_TEST_ASSERT(strncmp((const char*)list->data, "Hello", 5) == 0, "failed"); UCX_TEST_ASSERT(strncmp((const char*)list->next->data, " World!", 7) == 0, "failed"); UCX_TEST_ASSERT(list->next->next == NULL, "failed"); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_equals) { UcxList *list = ucx_list_append(NULL, (void*)"Hello"); list = ucx_list_append(list, (void*)" World!"); UcxList *list2 = ucx_list_prepend(NULL, (void*)" World!"); list2 = ucx_list_prepend(list2, (void*)"Hello"); UcxList *list3 = ucx_list_prepend(NULL, (void*)" Welt!"); list3 = ucx_list_prepend(list3, (void*)"Hallo"); UCX_TEST_BEGIN UCX_TEST_ASSERT(ucx_list_equals(list, list2, ucx_strcmp, NULL), "failed"); UCX_TEST_ASSERT(!ucx_list_equals(list, list3, ucx_strcmp, NULL), "failed"); UCX_TEST_END ucx_list_free(list3); ucx_list_free(list2); ucx_list_free(list); } UCX_TEST(test_ucx_list_concat) { UcxList *list = ucx_list_append(NULL, (void*)"Hello"); UcxList *list2 = ucx_list_prepend(NULL, (void*)" World!"); UCX_TEST_BEGIN list = ucx_list_concat(list, list2); UCX_TEST_ASSERT(strncmp((const char*)list->data, "Hello", 5) == 0, "failed"); UCX_TEST_ASSERT(strncmp((const char*)list->next->data, " World!", 7) == 0, "failed"); UCX_TEST_ASSERT(list->next->next == NULL, "failed"); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_size) { UcxList *list = ucx_list_append(NULL, (void*)"This "); list = ucx_list_append(list, (void*)"list "); list = ucx_list_append(list, (void*)"has "); list = ucx_list_append(list, (void*)"size "); list = ucx_list_append(list, (void*)"5!"); UCX_TEST_BEGIN UCX_TEST_ASSERT(ucx_list_size(list) == 5, "failed"); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_first) { UcxList *list = ucx_list_append(NULL, (void*)"Find "); list = ucx_list_append(list, (void*)"the "); list = ucx_list_append(list, (void*)"first!"); UCX_TEST_BEGIN const char* first = (const char*) (ucx_list_first(list)->data); UCX_TEST_ASSERT(strncmp(first, "Find ", 5) == 0, "failed"); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_last) { UcxList *list = ucx_list_append(NULL, (void*)"Find "); list = ucx_list_append(list, (void*)"the "); list = ucx_list_append(list, (void*)"last!"); UCX_TEST_BEGIN const char* last = (const char*) (ucx_list_last(list)->data); UCX_TEST_ASSERT(strncmp(last, "last!", 5) == 0, "failed"); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_get) { UcxList *list = ucx_list_append(NULL, (void*)"Find "); list = ucx_list_append(list, (void*)"the "); list = ucx_list_append(list, (void*)"mid!"); UCX_TEST_BEGIN const char* mid = (const char*) (ucx_list_get(list, 1)->data); UCX_TEST_ASSERT(strncmp(mid, "the ", 4) == 0, "failed"); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_indexof) { UcxList *list = ucx_list_append(NULL, (void*)"Find "); list = ucx_list_append(list, (void*)"the "); list = ucx_list_append(list, (void*)"mid!"); UCX_TEST_BEGIN UCX_TEST_ASSERT(ucx_list_indexof(list, list) == 0, "failed"); UCX_TEST_ASSERT(ucx_list_indexof(list, list->next) == 1, "failed"); UCX_TEST_ASSERT(ucx_list_indexof(list, ucx_list_get(list, 2)) == 2, "failed"); UcxList *otherlist = ucx_list_append(NULL, (void*) "foobar"); UCX_TEST_ASSERT(ucx_list_indexof(list, otherlist) == -1, "failed"); ucx_list_free(otherlist); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_find) { UcxList *l = ucx_list_append(NULL, (void*)"find "); l = ucx_list_append(l, (void*)"some "); l = ucx_list_append(l, (void*)"string!"); UCX_TEST_BEGIN UCX_TEST_ASSERT(ucx_list_find(l,(void*)"some ",ucx_strcmp,NULL) == 1, "doesn't find string"); UCX_TEST_ASSERT(ucx_list_find(l,(void*)"a",ucx_strcmp,NULL) == -1, "finds non-existing string"); UCX_TEST_END ucx_list_free(l); } UCX_TEST(test_ucx_list_contains) { UcxList *l = ucx_list_append(NULL, (void*)"Contains "); l = ucx_list_append(l, (void*)"a "); l = ucx_list_append(l, (void*)"string!"); UCX_TEST_BEGIN UCX_TEST_ASSERT(ucx_list_contains(l,(void*)"a ",ucx_strcmp,NULL), "false negative"); UCX_TEST_ASSERT(!ucx_list_contains(l,(void*)"a",ucx_strcmp,NULL), "false positive"); UCX_TEST_END ucx_list_free(l); } UCX_TEST(test_ucx_list_remove) { UcxList *list = ucx_list_append(NULL, (void*)"Hello"); list = ucx_list_append(list, (void*)" fucking"); list = ucx_list_append(list, (void*)" World!"); UCX_TEST_BEGIN list = ucx_list_remove(list, ucx_list_get(list, 1)); UCX_TEST_ASSERT(strncmp((const char*)list->data, "Hello", 5) == 0, "failed"); UCX_TEST_ASSERT(strncmp((const char*)list->next->data, " World!", 7) == 0, "failed"); UCX_TEST_ASSERT(list->next->next == NULL, "failed"); UCX_TEST_END ucx_list_free(list); } UCX_TEST(test_ucx_list_clone) { char *hello = (char*)malloc(6); char *world = (char*)malloc(8); memcpy(hello, "Hello", 6); memcpy(world, " World!", 8); UcxList *list = ucx_list_append(NULL, hello); list = ucx_list_append(list, world); UcxList *copy = ucx_list_clone(list, ucx_strcpy, NULL); UCX_TEST_BEGIN UCX_TEST_ASSERT(ucx_list_equals(list, copy, ucx_strcmp, NULL), "failed"); UCX_TEST_ASSERT(hello != copy->data, "first element is no copy"); UCX_TEST_ASSERT(world != copy->next->data, "second element is no copy"); UCX_TEST_END free(copy->next->data); free(copy->data); free(world); free(hello); ucx_list_free(list); ucx_list_free(copy); } UCX_TEST(test_ucx_list_sort) { UcxList *list = ucx_list_append(NULL, (void*)"this"); list = ucx_list_append(list, (void*)"is"); list = ucx_list_append(list, (void*)"a"); list = ucx_list_append(list, (void*)"test"); list = ucx_list_append(list, (void*)"for"); list = ucx_list_append(list, (void*)"partial"); list = ucx_list_append(list, (void*)"correctness"); UcxList *expected = ucx_list_append(NULL, (void*)"a"); expected = ucx_list_append(expected, (void*)"correctness"); expected = ucx_list_append(expected, (void*)"for"); expected = ucx_list_append(expected, (void*)"is"); expected = ucx_list_append(expected, (void*)"partial"); expected = ucx_list_append(expected, (void*)"test"); expected = ucx_list_append(expected, (void*)"this"); list = ucx_list_sort(list, ucx_strcmp, NULL); UCX_TEST_BEGIN UCX_TEST_ASSERT( ucx_list_equals(list, expected, ucx_strcmp, NULL), "failed"); UcxList *l = list; UCX_TEST_ASSERT(l->prev == NULL, "prev field of first entry is not null"); while (l->next != NULL) { UCX_TEST_ASSERT(l->next->prev == l, "prev pointer corrupted"); l = l->next; } UCX_TEST_END ucx_list_free(expected); ucx_list_free(list); }