Wed, 06 Jan 2021 16:41:09 +0100
single-use constant field can be inlined
<%-- DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER. Copyright 2021 Mike Becker. All rights reserved. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. --%> <%@page pageEncoding="UTF-8" %> <%@taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %> <%@taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %> <jsp:useBean id="viewmodel" type="de.uapcore.lightpit.viewmodel.IssueEditView" scope="request"/> <c:set var="issue" scope="page" value="${viewmodel.issue}" /> <%-- TODO: change to ./issues/commit --%> <form action="./projects/commit-issue" method="post"> <table class="formtable fullwidth"> <colgroup> <col> <col style="width: 100%"> </colgroup> <tbody> <c:if test="${viewmodel.issue.id ge 0}"> <tr> <th><fmt:message key="issue.id"/></th> <td>${issue.id}</td> </tr> </c:if> <tr> <th><fmt:message key="project"/></th> <td> <c:choose> <c:when test="${not empty issue.project}"> <c:out value="${issue.project.name}" /> <input type="hidden" name="pid" value="${issue.project.id}" /> </c:when> <c:otherwise> <select name="pid" required> <c:forEach var="project" items="${viewmodel.projects}"> <option value="${project.id}"> <c:out value="${project.name}" /> </option> </c:forEach> </select> </c:otherwise> </c:choose> </td> </tr> <tr> <th><fmt:message key="issue.created"/></th> <td> <c:set var="dateValue" value="${issue.created}"/> <%@include file="../jspf/date-with-tooltip.jspf"%> </td> </tr> <tr> <th><fmt:message key="issue.updated"/></th> <td> <c:set var="dateValue" value="${issue.updated}"/> <%@include file="../jspf/date-with-tooltip.jspf"%> </td> </tr> <tr> <th><fmt:message key="component"/></th> <td> <select name="component"> <option value="-1"><fmt:message key="placeholder.null-component"/></option> <c:forEach var="component" items="${viewmodel.components}"> <option <c:if test="${not empty issue.component and component eq issue.component}">selected</c:if> <c:if test="${empty issue.component and component.id eq cid}">selected</c:if> value="${component.id}"><c:out value="${component.name}"/></option> </c:forEach> </select> </td> </tr> <tr> <th><fmt:message key="issue.category"/></th> <td> <select name="category"> <c:forEach var="category" items="${viewmodel.issueCategory}"> <option <c:if test="${category eq issue.category}">selected</c:if> value="${category}"> <fmt:message key="issue.category.${category}" /> </option> </c:forEach> </select> </td> </tr> <tr> <th><fmt:message key="issue.status"/></th> <td> <select name="status"> <c:forEach var="status" items="${viewmodel.issueStatus}"> <option <c:if test="${status eq issue.status}">selected</c:if> value="${status}"> <fmt:message key="issue.status.${status}" /> </option> </c:forEach> </select> </td> </tr> <tr> <th><fmt:message key="issue.subject"/></th> <td><input name="subject" type="text" maxlength="200" required value="<c:out value="${issue.subject}"/>" /></td> </tr> <tr> <th class="vtop"><fmt:message key="issue.description"/></th> <td> <textarea name="description" rows="10"><c:out value="${issue.description}"/></textarea> </td> </tr> <tr> <th><fmt:message key="issue.assignee"/></th> <td> <select name="assignee"> <option value="-2" title="<fmt:message key="placeholder.auto-assignee.tooltip"/>"><fmt:message key="placeholder.auto-assignee"/></option> <option value="-1" <c:if test="${issue.id ge 0 and empty issue.assignee}">selected</c:if> ><fmt:message key="placeholder.null-assignee"/></option> <c:forEach var="user" items="${viewmodel.users}"> <option <c:if test="${not empty issue.assignee and user eq issue.assignee}">selected</c:if> value="${user.id}"><c:out value="${user.displayname}"/></option> </c:forEach> </select> </td> </tr> <c:if test="${issue.project.id ge 0}"> <tr> <th class="vtop"><fmt:message key="issue.affected-versions"/></th> <td> <c:set var="fieldname" value="affected"/> <c:set var="selectionList" value="${viewmodel.versionsRecent}"/> <c:set var="data" value="${issue.affectedVersions}" /> <%@include file="../jspf/version-list.jspf"%> </td> </tr> <tr> <th class="vtop"><fmt:message key="issue.resolved-versions"/></th> <td> <c:set var="fieldname" value="resolved"/> <c:set var="selectionList" value="${viewmodel.versionsUpcoming}"/> <c:set var="data" value="${issue.resolvedVersions}" /> <%@include file="../jspf/version-list.jspf"%> </td> </tr> </c:if> <tr> <th><fmt:message key="issue.eta"/></th> <td><input name="eta" type="date" value="<fmt:formatDate value="${issue.eta}" pattern="YYYY-MM-dd" />" /> </td> </tr> </tbody> <tfoot> <tr> <td colspan="2"> <input type="checkbox" id="create-another" name="create-another" <c:if test="${more}">checked</c:if> /> <label for="create-another"><fmt:message key="button.issue.create.another"/> </label> <input type="hidden" name="id" value="${issue.id}"/> <c:if test="${issue.id ge 0}"> <a href="./projects/${issue.project.node}/issues/${issue.id}/view" class="button"> <fmt:message key="button.cancel"/> </a> </c:if> <c:if test="${issue.id lt 0}"> <%-- TODO: fix #14 --%> <a href="./projects/${issue.project.node}/all-components/all-versions/issues/" class="button"> <fmt:message key="button.cancel"/> </a> </c:if> <button type="submit"><fmt:message key="button.okay"/></button> </td> </tr> </tfoot> </table> </form>